Refactor ASP handling to use current iASP name and fetch additional information #2339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: worksofliam <[email protected]>
…sourceASP property Signed-off-by: worksofliam <[email protected]>
Signed-off-by: worksofliam <[email protected]>
Signed-off-by: worksofliam <[email protected]>
Signed-off-by: worksofliam <[email protected]>
Signed-off-by: worksofliam <[email protected]>
Signed-off-by: worksofliam <[email protected]>
|
Ping @sebjulliand - please take a look at this in the next couple of weeks if you can. |
Signed-off-by: worksofliam <[email protected]>
|
👋 A new build is available for this PR based on 1953ac7. |
Signed-off-by: worksofliam <[email protected]>
…of awaiting them Signed-off-by: worksofliam <[email protected]>
…new content methods Signed-off-by: worksofliam <[email protected]>
Signed-off-by: worksofliam <[email protected]>
sebjulliand
reviewed
Jan 15, 2025
sebjulliand
reviewed
Jan 15, 2025
Signed-off-by: Seb Julliand <[email protected]>
Signed-off-by: Seb Julliand <[email protected]>
Signed-off-by: Seb Julliand <[email protected]>
Co-authored-by: Sébastien Julliand <[email protected]>
Co-authored-by: Sébastien Julliand <[email protected]>
|
@sebjulliand The merge here too complex to make it worth it. I will need to do it. This is a worthy PR I think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the handling of ASPs to utilize the current iASP name instead of the deprecated sourceASP property, and enhance the fetching of ASP information by RDB name.
This means that Code for IBM i will always use the ASP that is defined as part of their user profile / job description.
The downside about this PR is I actually have no systems to test it on. So I kind of buggered up there.
Checklist
IBMiclass